Moar tests #99
Closed
Moar tests #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also move the caught exceptions around os.unlink() to be more explicit
If you set whisper.CACHE_HEADERS to True and run whisper.info to cache the headers, the cached version will always be used even if whisper.CACHE_HEADERS is still used.
Once the coverage is a bit more up to spec, I can actually refactor some of these bits and still sleep at night.
This was removed when I rebase removed my py3k support changes as @brutasse opened graphite-project#70 long before I had this all ready to merge.
If there isn't an exception raised for any of the loops, it should fail the test.
|
@brutasse, @esc, or @obfuscurity can you take a look at this? To look at the coverage numbers, I'm doing this with master and my moar-tests branch: |
|
Re-opening after rebasing a bit and upping the coverage even further. |
|
Replaced by #100 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I started working on py3k support, but since I was re-reminded of @brutasse's #70, I rebased and deleted those commits. Additionally, due to #98, which I also did, I rebase deleted those commits as @amosshapira took care of that first :)
Anyways, this brings up the total test coverage of whisper.py up from 67 --> 76%. I'll be slowly continuing to update this, but it can be merged now.