Throw better error when polymorphic type not found #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richmolj
force-pushed
the
polymorphic_error
branch
from
ddc1de2
to
0b7c716
Compare
wadetandy
approved these changes
Apr 4, 2019
lib/graphiti/errors.rb
Outdated
| polymorphic_belongs_to #{@sideload.name.inspect} do | ||
| group_by(#{@sideload.grouper.field_name.inspect}) do | ||
| on(:foo) | ||
| on(:foo).belongs_to :foo, resource: FooResource (long-hand example) |
There was a problem hiding this comment.
Pedantic fix: on(:foo).belongs_to :foo, resource: FooResource # (long-hand example)
richmolj
force-pushed
the
polymorphic_error
branch
from
0b7c716
to
63d91cd
Compare
If you are sideposting a polymorphic relationship, and pass a jsonapi type that is not registered, we would throw a confusing error. Now we throw an explicit error with information about what's happening.
richmolj
force-pushed
the
polymorphic_error
branch
from
63d91cd
to
b6a5df1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you are sideposting a polymorphic relationship, and pass a jsonapi
type that is not registered, we would throw a confusing error. Now we
throw an explicit error with information about what's happening.