Fix Sparse fieldsets to work with relationships #389
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #301
The sparse fieldsets is not filtering relationships. Currently if we specify any attribute and/or relationship in
fields
param, it works correctly on attributes but the not on relationships. It returns all the relationships, ignoringfields
param. According to jsonapi format both attribute and relationship should be supported. This PR fixes that.In case of
fields
param having only attribute(s) in them, this change will restrict all relationships as well because of the following line from jsonapi format doc (fields represent both attributes and relationships)I have not changed
include
section because of the following specification from the jsonapi format doc.So in case of having a relationship mentioned in
include
and sparse fieldsets having some atttribute, this will still return the relationship but the linkage won't be there.