Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer #update over #update_attributes #423

Merged
merged 1 commit into from
Jun 30, 2022

Conversation

jkeen
Copy link
Collaborator

@jkeen jkeen commented Jun 28, 2022

Using/allowing @resource.update instead of @resource.update_attributes might help out a lot of rubocop + graphiti users, as Rubocop loves to think that @resource.update_attributes is out-of-date Rails code and will automatically change it to @resource.update which before this update broke things.

This keeps graphiti a little more in sync with the standard Railsy controller pattern

… and rubocop loves to auto-correct graphiti into a broken state without this
@jkeen
Copy link
Collaborator Author

jkeen commented Jun 28, 2022

Note: Base64 and Position related test failures are addressed in #422

@richmolj
Copy link
Contributor

Thanks Jeff LGTM but could you give some context on the spec failures? Were they failing prior to this PR?

@jkeen
Copy link
Collaborator Author

jkeen commented Jun 28, 2022

@richmolj They were, they're actually failing in a bunch of the open PRs. It's completely unrelated to this change. While prepping this I noticed them and PR'd that fix early.

If you can approve and merge #422 a bunch of the failures will get resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants