Prefer #update over #update_attributes #423
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using/allowing
@resource.update
instead of@resource.update_attributes
might help out a lot of rubocop + graphiti users, as Rubocop loves to think that@resource.update_attributes
is out-of-date Rails code and will automatically change it to@resource.update
which before this update broke things.This keeps graphiti a little more in sync with the standard Railsy controller pattern