-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added i3 extractor and general dataconverter #1
Conversation
dataconveter
…: Does not inherit from dataconverter! Sorry Andreas!
Hi @RasmusOrsoe, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @RasmusOrsoe,
Thanks for adding all of this hard work to our common repo! 🥳 Brilliant to get the ball rolling like this, and I look forward to getting the first batch of material into main
.
I have tried to proved some comments and suggestions for each of the four added files. Please let me know if anything is unclear, if you disagree with my suggestions, and if there is anything I can do to help out.
I have addressed the vast majority of issues and I vote that we for now live with the fact that the parallelized function in the i3dataconverter lives outside the class. Also: The code runs and works. :-) |
Hi @RasmusOrsoe, |
No description provided.