Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added i3 extractor and general dataconverter #1

Merged
merged 3 commits into from
Sep 23, 2021
Merged

Added i3 extractor and general dataconverter #1

merged 3 commits into from
Sep 23, 2021

Conversation

RasmusOrsoe
Copy link
Collaborator

No description provided.

@asogaard asogaard self-assigned this Sep 21, 2021
@asogaard asogaard self-requested a review September 21, 2021 14:50
…: Does not inherit from dataconverter! Sorry Andreas!
@asogaard
Copy link
Collaborator

Hi @RasmusOrsoe,
Just FYI: As this is a somewhat large PR (+788 lines), in the interest of merging the code relatively quickly, I will try to limit me feedback to overall code structure and functionality, and hold off on other stuff (linting, docstrings, unit tests, etc.). I am happy to work on this after this PR is merged.

Copy link
Collaborator

@asogaard asogaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @RasmusOrsoe,
Thanks for adding all of this hard work to our common repo! 🥳 Brilliant to get the ball rolling like this, and I look forward to getting the first batch of material into main.

I have tried to proved some comments and suggestions for each of the four added files. Please let me know if anything is unclear, if you disagree with my suggestions, and if there is anything I can do to help out.

src/data/utils.py Show resolved Hide resolved
src/data/utils.py Outdated Show resolved Hide resolved
src/data/utils.py Outdated Show resolved Hide resolved
src/data/utils.py Outdated Show resolved Hide resolved
src/data/utils.py Outdated Show resolved Hide resolved
src/data/sqlite_converter.py Outdated Show resolved Hide resolved
src/data/sqlite_converter.py Outdated Show resolved Hide resolved
src/data/sqlite_converter.py Outdated Show resolved Hide resolved
src/data/sqlite_converter.py Outdated Show resolved Hide resolved
src/data/test_sqlite.py Outdated Show resolved Hide resolved
@asogaard asogaard assigned RasmusOrsoe and unassigned asogaard Sep 22, 2021
@RasmusOrsoe
Copy link
Collaborator Author

RasmusOrsoe commented Sep 22, 2021

I have addressed the vast majority of issues and I vote that we for now live with the fact that the parallelized function in the i3dataconverter lives outside the class.

Also:

The code runs and works. :-)

@asogaard
Copy link
Collaborator

Hi @RasmusOrsoe,
Thanks for all of the comments and the code changes! I complete agree that we merge this PR and follow up on whatever remains through separate PRs/issues. Great job! 🥳

@asogaard asogaard merged commit 9c75487 into graphnet-team:main Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SQLiteDataConverter class Add DataConverter class Add I3Extractor class
2 participants