Configure package according to proposed directory structure #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RasmusOrsoe
reviewed
Sep 23, 2021
|
I have addressed the review comments, @RasmusOrsoe. Please let me know whether you are happy with the proposed resolution. :) |
|
Have merged the changes from #13 into this PR, which should therefore be ready to merge. |
RasmusOrsoe
approved these changes
Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have moved the files around a little bit to match the proposed directory structure (see wiki), added setup and init files to expose a
gnn_recopackage, and have move the SQLiteDataConverter MWE script to a newexamplesdirectory. It should be possible to run this script by activating the icetray shell, installing thegnn_recopackage, and runningpython examples/test_sqlite.py.