Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stopmuon func in utils, add labels to i3extractor #148

Merged
merged 5 commits into from
Feb 4, 2022
Merged

Stopmuon func in utils, add labels to i3extractor #148

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3dffd38
Stopmuon func in utils, add labels to i3extractor
BozianuLeon Jan 27, 2022
44efd1e
Auto-updating lint badge
asogaard Jan 27, 2022
d172e56
Change borders to self._borders
BozianuLeon Jan 28, 2022
8aa8864
Merge branch 'stop_mu' of https://github.com/BozianuLeon/gnn-reco int…
BozianuLeon Jan 28, 2022
b611b26
Merge branch 'main' into stop_mu
RasmusOrsoe Feb 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions misc/badges/pylint.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
13 changes: 12 additions & 1 deletion src/graphnet/data/i3extractor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
print("icecube package not available.")

from abc import abstractmethod
from .utils import frame_has_key
from .utils import frame_has_key,muon_stopped


class I3Extractor(ABC):
Expand Down Expand Up @@ -238,6 +238,17 @@ def __call__(self, frame, padding_value=-1) -> dict:
'interaction_type': interaction_type,
'elasticity': elasticity,
})
if abs(output['pid'])==13:
output.update({
'track_length': MCInIcePrimary.length,
})
final_position, stopped = muon_stopped(output)
output.update({
'final_position_x': final_position[0],
'final_position_y': final_position[1],
'final_position_z': final_position[2],
'stopped_muon': stopped,
})

return output

Expand Down
29 changes: 29 additions & 0 deletions src/graphnet/data/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import os
import numpy as np
import pandas as pd
import matplotlib.path as mpath
from pathlib import Path
import re
from typing import List, Tuple
Expand Down Expand Up @@ -249,3 +250,31 @@ def frame_has_key(frame, key: str):
return True
except:
return False

def muon_stopped(truth, horizontal_pad = 100, vertical_pad = 100):
'''
Determine if a simulated muon stops inside the fiducial volume of the IceCube detector as defined in the RIDE study.
Vertical and horizontal pad shrink fiducial volume further.
Using track length, azimuth and zenith travel from the starting/generation point,
also return x,y,z of muon end point (to be reconstructed)
'''
#to do:remove hard-coded border coords and replace with GCD file contents using string no's
border_coords = np.array([(-256.1400146484375, -521.0800170898438), (-132.8000030517578, -501.45001220703125), (-9.13000011444092, -481.739990234375), (114.38999938964844, -461.989990234375), (237.77999877929688, -442.4200134277344), (361.0, -422.8299865722656), (405.8299865722656, -306.3800048828125), (443.6000061035156, -194.16000366210938), (500.42999267578125, -58.45000076293945), (544.0700073242188, 55.88999938964844), (576.3699951171875, 170.9199981689453), (505.2699890136719, 257.8800048828125), (429.760009765625, 351.0199890136719), (338.44000244140625, 463.7200012207031), (224.5800018310547, 432.3500061035156), (101.04000091552734, 412.7900085449219), (22.11000061035156, 509.5), (-101.05999755859375, 490.2200012207031), (-224.08999633789062, 470.8599853515625), (-347.8800048828125, 451.5199890136719), (-392.3800048828125, 334.239990234375), (-437.0400085449219, 217.8000030517578), (-481.6000061035156, 101.38999938964844), (-526.6300048828125, -15.60000038146973), (-570.9000244140625, -125.13999938964844), (-492.42999267578125, -230.16000366210938), (-413.4599914550781, -327.2699890136719), (-334.79998779296875, -424.5)])
border_z = [-512.82,524.56]
border = mpath.Path(border_coords)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we refactor this and perhaps change the variable naming?

It looks like border_coords is indeed xy-coordinates, and if this is true, then lets please rename to border_xy.

It would be nice if we could add a single input parameter borders to the truth extractor that defaults to this choice.

We could save the border input variable as self._borders and then

if self._borders == None:
  border_xy = np.array([(-256.1400146484375, -521.0800170898438), (-132.8000030517578, -501.45001220703125), (-9.13000011444092, -481.739990234375), (114.38999938964844, -461.989990234375), (237.77999877929688, -442.4200134277344), (361.0, -422.8299865722656), (405.8299865722656, -306.3800048828125), (443.6000061035156, -194.16000366210938), (500.42999267578125, -58.45000076293945), (544.0700073242188, 55.88999938964844), (576.3699951171875, 170.9199981689453), (505.2699890136719, 257.8800048828125), (429.760009765625, 351.0199890136719), (338.44000244140625, 463.7200012207031), (224.5800018310547, 432.3500061035156), (101.04000091552734, 412.7900085449219), (22.11000061035156, 509.5), (-101.05999755859375, 490.2200012207031), (-224.08999633789062, 470.8599853515625), (-347.8800048828125, 451.5199890136719), (-392.3800048828125, 334.239990234375), (-437.0400085449219, 217.8000030517578), (-481.6000061035156, 101.38999938964844), (-526.6300048828125, -15.60000038146973), (-570.9000244140625, -125.13999938964844), (-492.42999267578125, -230.16000366210938), (-413.4599914550781, -327.2699890136719), (-334.79998779296875, -424.5)])
  border_z = [-512.82,524.56]
  border = mpath.Path(border_xy)
else:
     border_xy = borders[0]
     border_z   = borders[1]

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completely agree, although I left the path.Path to the utils function so no need to import matplotlib in i3extractor.


start_pos = np.array([truth['position_x'],
truth['position_y'],
truth['position_z']])

travel_vec = -1*np.array([truth['track_length']*np.cos(truth['azimuth'])*np.sin(truth['zenith']),
truth['track_length']*np.sin(truth['azimuth'])*np.sin(truth['zenith']),
truth['track_length']*np.cos(truth['zenith'])])

end_pos = start_pos+travel_vec

stopped_xy = border.contains_point((end_pos[0],end_pos[1]),radius=-horizontal_pad)
stopped_z = (end_pos[2] > border_z[0] + vertical_pad) * (end_pos[2] < border_z[1] - vertical_pad)
stopped_muon = stopped_xy * stopped_z

return end_pos,stopped_muon