Changed i3featureextractor.py to also extract the event datetime from frame I3EventHeader. #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… frame I3EventHeader.
asogaard
requested changes
Oct 11, 2022
There was a problem hiding this comment.
Hi @Peterandresen12,
Thanks for this PR! 🚀 While I think it is a little inefficient for us to add the event time to all pulses, rather than just once per event, I realise that this is the best/only way to do it currently, so I'm not going to push back on that. I have added on suggestion but otherwise I think this is fine to merge. :)
asogaard
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have changed the i3featureextractor.py to also extract the datetime of the events, which can for instance be used to identify the moon position at the time of each event. The datetime is required for the
icecube.astro.I3GetMoonDirection()https://docs.icecube.aq/icetray/main/projects/astro/index.html