Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build pipeline #35

Merged
merged 4 commits into from
Oct 21, 2021
Merged

Build pipeline #35

merged 4 commits into from
Oct 21, 2021

Conversation

asogaard
Copy link
Collaborator

Have coverage script point to gnn_reco package rather than src/ directory for source code, as the latter only works if the package is installed as locally editable (i.e., pip install -e (...)). This change should produce actual coverage results and, as a result, an informative coverage badge.

Also fixed a warning from github-pages action, by replacing {name,email} variables with git-config-{name,email}.

@asogaard asogaard added the bug Something isn't working label Oct 19, 2021
@asogaard asogaard self-assigned this Oct 19, 2021
@asogaard asogaard added this to Review in Initial repository setup via automation Oct 19, 2021
@asogaard asogaard merged commit 675fa11 into graphnet-team:main Oct 21, 2021
Initial repository setup automation moved this from Review to Done Oct 21, 2021
@asogaard asogaard deleted the build-pipeline branch October 21, 2021 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants