Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test_model_training_sqlite.py #66

Merged
merged 1 commit into from
Nov 11, 2021
Merged

Update test_model_training_sqlite.py #66

merged 1 commit into from
Nov 11, 2021

Conversation

RasmusOrsoe
Copy link
Collaborator

quickfix

asogaard
asogaard approved these changes Nov 11, 2021
View reviewed changes
Copy link
Collaborator

@asogaard asogaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We will still need to resolve the duplication in gnn_reco.components.utils wrt. gnn_reco.model_training.utils, as noted in the former file, but let's leave it at that for now.

@asogaard asogaard merged commit e950c7a into graphnet-team:main Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asogaard asogaard asogaard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RasmusOrsoe @asogaard