Cast single path to list of paths in DataConverter.merge_files
#726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aske-Rosted
reviewed
May 22, 2024
There was a problem hiding this comment.
While the issue mentions that the user should be made aware of issue by raising a more sensible warning. This "fixes" the users mistake but ultimately runs a merge_files script on a single file. Is there some scenario where this action makes sense? Or is there something I am missing?
|
@Aske-Rosted thanks for pointing this out. That is why we have reviews! I updated the code to prompt an info message and return without merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #711