Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor tweaks #79

Merged
merged 6 commits into from
Nov 18, 2021
Merged

Minor tweaks #79

merged 6 commits into from
Nov 18, 2021

Conversation

asogaard
Copy link
Collaborator

Fix some broken imports, avoid modifying the frame inplace in the I3Extractor (this is bad for inference in an I3Module), and fix the pytorch-geometric version to 2.0.1 for consistency.

@RasmusOrsoe Consider pulling these changes before a clean clone and retraining.

@asogaard asogaard added the bug Something isn't working label Nov 18, 2021
@asogaard asogaard self-assigned this Nov 18, 2021
Copy link
Collaborator

@RasmusOrsoe RasmusOrsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool beans. Approved

@RasmusOrsoe RasmusOrsoe merged commit 5481ea1 into graphnet-team:main Nov 18, 2021
@asogaard asogaard deleted the minor-tweaks branch November 19, 2021 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants