Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Training on upgrade MC #96

Merged
merged 10 commits into from
Dec 11, 2021
Merged

Conversation

asogaard
Copy link
Collaborator

@asogaard asogaard commented Dec 9, 2021

Have added a script to train on mDOM data from Upgrade MC. The two main additions are:

  1. Adding a Detector class for IceCube-Upgrade that preprocesses the new features.
  2. Filtering events with < 2 DOM hits when batching. This is not an uncommon occurrence in the available Upgrade MC (probably all truth events are kept if they are reconstructed with any of the multiple available pulse maps).

Addresses #47 but doesn't close it quite yet.

Tagging @mhaminh for you information

@asogaard asogaard added the feature New feature or request label Dec 9, 2021
@asogaard asogaard added this to Review in Initial repository setup via automation Dec 9, 2021
@asogaard asogaard self-assigned this Dec 9, 2021
Copy link
Collaborator

@RasmusOrsoe RasmusOrsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Andreas! Nice!

One question; why are we throwing away 2-pulse events? I think these would be extremely rare if we included all DOM types as input and not just the MDoms from your training example.

Rasmus

@asogaard
Copy link
Collaborator Author

We're keeping 2-pulse events but throwing away 0-pulse events (ill-defined graph) and 1-pulse events (homophily or whatever it's called doesn't seem to work for just one node). And I agree, in practice this should not occur, so it's mainly just as a safeguard to make to it possible to run over the current Upgrade MC files.

@RasmusOrsoe RasmusOrsoe self-requested a review December 11, 2021 09:45
Copy link
Collaborator

@RasmusOrsoe RasmusOrsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes ofc! I was a bit tired when I went over it. Approved!

@asogaard asogaard merged commit 5e217a4 into graphnet-team:main Dec 11, 2021
Initial repository setup automation moved this from Review to Done Dec 11, 2021
@asogaard asogaard deleted the training-on-upgrade-mc branch December 11, 2021 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants