-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Training on upgrade MC #96
Training on upgrade MC #96
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Andreas! Nice!
One question; why are we throwing away 2-pulse events? I think these would be extremely rare if we included all DOM types as input and not just the MDoms from your training example.
Rasmus
We're keeping 2-pulse events but throwing away 0-pulse events (ill-defined graph) and 1-pulse events (homophily or whatever it's called doesn't seem to work for just one node). And I agree, in practice this should not occur, so it's mainly just as a safeguard to make to it possible to run over the current Upgrade MC files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes ofc! I was a bit tired when I went over it. Approved!
Have added a script to train on mDOM data from Upgrade MC. The two main additions are:
Detector
class for IceCube-Upgrade that preprocesses the new features.Addresses #47 but doesn't close it quite yet.
Tagging @mhaminh for you information