Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

local file system and remote object storage #54

Merged
merged 9 commits into from
Mar 7, 2024
Merged

Conversation

hopeyen
Copy link
Collaborator

@hopeyen hopeyen commented Mar 7, 2024

Description

Instead of std::fs, use [object_store] (https://crates.io/crates/object_store) from Apache Arrow.

  • Allowed for both consumer write and provider read
  • multipart write and vectorized read for both FS and OS
  • /tmp/bucket/... is used to store the bytes during download for precise writing of the chunks, then uploaded to the bucket after complete download
  • file system files and objects can be used interchangeably, but with different configurations
  • updated unit/e2e tests and benchmarks

Issue link (if applicable)

Resolves #15

Checklist

  • Are tests up-to-date with the new changes?
  • Are docs up-to-date with the new changes? (Open PR on docs repo if necessary)

@hopeyen hopeyen added size:large Large p1 High priority type:feature New or enhanced functionality labels Mar 7, 2024
@hopeyen hopeyen self-assigned this Mar 7, 2024
Copy link

github-actions bot commented Mar 7, 2024

Pull Request Test Coverage Report for Build 8194223349

Details

  • 0 of 672 (0.0%) changed or added relevant lines in 16 files are covered.
  • 8 unchanged lines in 4 files lost coverage.
  • Overall coverage remained the same at 0.0%

Changes Missing Coverage Covered Lines Changed/Added Lines %
file-exchange/src/discover/mod.rs 0 1 0.0%
file-exchange/src/download_client/range_request.rs 0 1 0.0%
file-exchange/src/manifest/manifest_fetcher.rs 0 1 0.0%
file-service/src/file_server/cost.rs 0 2 0.0%
file-exchange/src/manifest/mod.rs 0 5 0.0%
file-service/src/file_server/mod.rs 0 5 0.0%
file-service/src/file_server/status.rs 0 5 0.0%
file-exchange/src/test_util.rs 0 7 0.0%
file-exchange/src/config.rs 0 12 0.0%
file-service/src/file_server/service.rs 0 16 0.0%
Files with Coverage Reduction New Missed Lines %
file-exchange/src/config.rs 1 0.0%
file-exchange/src/manifest/file_reader.rs 1 0.0%
file-exchange/src/manifest/mod.rs 3 0.0%
file-exchange/src/publisher/mod.rs 3 0.0%
Totals Coverage Status
Change from base Build 8143304729: 0.0%
Covered Lines: 0
Relevant Lines: 3586

💛 - Coveralls

@hopeyen hopeyen force-pushed the hope/remote-object-conn branch 2 times, most recently from 8677a74 to 6043a83 Compare March 7, 2024 20:12
@hopeyen hopeyen merged commit 6adcb0e into dev Mar 7, 2024
5 checks passed
@hopeyen hopeyen deleted the hope/remote-object-conn branch March 7, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1 High priority size:large Large type:feature New or enhanced functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spike: Generalize storage paths
1 participant