Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor POI radio as an example #11

Merged
merged 1 commit into from Dec 14, 2022
Merged

Conversation

hopeyen
Copy link
Collaborator

@hopeyen hopeyen commented Dec 13, 2022

Added a GossipAgent module for an initial refactoring of GossipMessages and specific radio usages.

Factor POI radio related operations and event loop to /examples.

Plan to further refactor query function and parsing function when implementing more dynamic queries and radio payload buffers.

To spin up example instance of POI crosschecker radio: cargo run --example poi-crosschecker [boot]

@axiomatic-aardvark
Copy link
Collaborator

Awesome work 🔥 this is just how I imagined the interface between the sdk and Radio to look like 🚀
Just one thing - at the top of the the Radio's main.rs file rust-analyzer says "file not included in module tree", I assume it's an issue with the cargo workspaces configuration 🤔 it causes rust-analyzer to be dodgy in the file and not show all lints, also I can't seem to click through struct/function definitions to inspect them

@axiomatic-aardvark
Copy link
Collaborator

Also I think we should completely extract the poi-crosschecker as its own repo but that can be after this week

@hopeyen
Copy link
Collaborator Author

hopeyen commented Dec 14, 2022

thanks for the feedback @axiomatic-aardvark !

I've added examples to the root Cargo.toml to include rust analyzer for the radio executable. It should now link you to things as you click.

  • Running cargo run --example poi-crosschecker [boot] should spin up a radio instance.

I agree that we can have a separate repo for POI cross-checker, additionally I think it can still live as an example here (and the ping-pong example) without active maintenance

@hopeyen hopeyen merged commit 32818c0 into main Dec 14, 2022
@hopeyen hopeyen deleted the hope/poi-example-refactor branch December 14, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants