Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default protocol from filter to relay, additional content topic filter #297

Merged
merged 2 commits into from Oct 31, 2023

Conversation

hopeyen
Copy link
Collaborator

@hopeyen hopeyen commented Oct 26, 2023

Description

  • Changed default behavior of protocol participation - now radio nodes will automatically participate in relay protocol and directly subscribe and publish to relay network
  • Updated network_check to connect to peers on the relay network and disregard connecting with lightpush and filter peers
  • Added an additional check to only handle messages of relevant content topics
  • Changed content topics to be in a std mutex instead of tokio mutex in order to use content topics upon signal handling in the waku event callback
  • Updated and tested with ping-pong example

Issue link (if applicable)

Resolves #295

No significant updates should be needed for dependent radios

Checklist

  • Are tests up-to-date with the new changes?
  • Are docs up-to-date with the new changes? (Open PR on docs repo if necessary)

@hopeyen hopeyen added type:refactor Changes not visible to users size:medium Medium p1 High priority labels Oct 26, 2023
@hopeyen hopeyen self-assigned this Oct 26, 2023
@chriswessels
Copy link
Member

This was quick. Great work. Do we need to notify the infra team of any bootnode config changes?

@hopeyen
Copy link
Collaborator Author

hopeyen commented Oct 30, 2023

This was quick. Great work. Do we need to notify the infra team of any bootnode config changes?

Thanks! No need to notify, the bootnodes are already on relay. We could turn off filter on bootnodes but that's not necessary, we will have to notify pubsub topic config changes if we do sharding later.

@hopeyen hopeyen merged commit 66f1afd into dev Oct 31, 2023
7 checks passed
@hopeyen hopeyen deleted the hope/filter-to-relay branch October 31, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1 High priority size:medium Medium type:refactor Changes not visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat.Req] Enable relay network with pubsub sharding
3 participants