Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove native-tls dependency #151

Merged
merged 1 commit into from
May 27, 2024
Merged

Conversation

petkodes
Copy link
Collaborator

Relating SDK PR - graphops/graphcast-sdk#327

@petkodes petkodes force-pushed the petko/remove-dependency-on-native-tls branch from fba1fc8 to c52edab Compare May 24, 2024 19:36
@petkodes petkodes self-assigned this May 24, 2024
hopeyen
hopeyen previously approved these changes May 27, 2024
Copy link
Collaborator

@hopeyen hopeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! looks like we already depend on rustls for lots of crates so good to move away from native-tls entirely.
(remainder to update graphcast-sdk dep path after that branch is merged)

@petkodes petkodes merged commit 3e9d6a5 into dev May 27, 2024
6 of 7 checks passed
@petkodes petkodes deleted the petko/remove-dependency-on-native-tls branch May 27, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants