Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codegen command generates setters for derived fields #943

Closed
georg-getz opened this issue Aug 9, 2022 · 2 comments · Fixed by #1193
Closed

Codegen command generates setters for derived fields #943

georg-getz opened this issue Aug 9, 2022 · 2 comments · Fixed by #1193
Assignees
Labels
bug Something isn't working

Comments

@georg-getz
Copy link
Contributor

The problem is that trying to call a setter of a derived field (some people do it when using matchstick) crashes on deployment because derived fields are supposed to only be derived from other entities and not be set ever.

@azf20
Copy link
Contributor

azf20 commented Aug 11, 2022

Thanks @georg-getz - agree that this is confusing
cc @evaporei

@KholdStare
Copy link

@evaporei @azf20 @dimitrovmaksim This just bit me - I was migrating away from manually setting a field to deriving it, and thought that building the graph would result in a compile error if a setter was being used anywhere. Turns out I missed removing a setter in one place, but only found out about it when the deployed graph had errors.

Just sharing another way this can affect users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants