Remove use of .wait()
#1352
Merged
Remove use of .wait()
#1352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing the node to hang at startup if the `network_identifiers` calls had to retry, for example due to rate limits.
Jannis
requested changes
Nov 14, 2019
node/src/main.rs
Outdated
| stores_logger, | ||
| "Connected to Ethereum"; | ||
| "network" => &network_name, | ||
| "network_version" => &network_identifier.net_version, |
There was a problem hiding this comment.
The indentation here is off.
Jannis
approved these changes
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing the node to hang at startup if the
network_identifierscalls had to retry, for example due to rate limits. Most of the diff is from having to indent the rest of main.