Fix extending EthereumCallFilter #1382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jannis
reviewed
Nov 25, 2019
Comment on lines
331
to
343
| for (key, (proposed_start_block, new_sigs)) in | ||
| other.contract_addresses_function_signatures.into_iter() | ||
| { | ||
| match self.contract_addresses_function_signatures.get_mut(&key) { | ||
| Some((existing_start_block, existing_sigs)) => { | ||
| *existing_start_block = | ||
| cmp::min(proposed_start_block, existing_start_block.clone()); | ||
| existing_sigs.extend(new_sigs); | ||
| } | ||
| None => { | ||
| self.contract_addresses_function_signatures | ||
| .insert(key, (proposed_start_block, new_sigs)); | ||
| } |
There was a problem hiding this comment.
We should call key address in this method. I got confused because I didn't know what key meant.
There was a problem hiding this comment.
The code looks good otherwise. It would be nice to have a test for this though.
Jannis
requested changes
Nov 25, 2019
Comment on lines
331
to
343
| for (key, (proposed_start_block, new_sigs)) in | ||
| other.contract_addresses_function_signatures.into_iter() | ||
| { | ||
| match self.contract_addresses_function_signatures.get_mut(&key) { | ||
| Some((existing_start_block, existing_sigs)) => { | ||
| *existing_start_block = | ||
| cmp::min(proposed_start_block, existing_start_block.clone()); | ||
| existing_sigs.extend(new_sigs); | ||
| } | ||
| None => { | ||
| self.contract_addresses_function_signatures | ||
| .insert(key, (proposed_start_block, new_sigs)); | ||
| } |
There was a problem hiding this comment.
The code looks good otherwise. It would be nice to have a test for this though.
|
Okay, let's add a test |
|
Test added @Jannis |
ghost
closed this
ghost
reopened this
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses graphprotocol/support#42