Create metrics to track block ingestion and GraphQL query execution #1403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jannis
requested changes
Dec 12, 2019
chain/ethereum/src/block_ingestor.rs
Outdated
| @@ -115,6 +147,10 @@ where | |||
| LogCode::BlockIngestionStatus | |||
| }; | |||
| if distance > 0 { | |||
| self.ingestor_metrics.observe_blocks_synced( | |||
There was a problem hiding this comment.
This is not the right place IMHO. At this point we have't written the block to our db yet, so as far as our system is concerned, we are not up to date with the chain yet.
There was a problem hiding this comment.
I think the right place would be an inspect here: https://github.com/graphprotocol/graph-node/pull/1403/files#diff-dc8c393601039a99522fbd9bdd37b8dbR233-R235
There was a problem hiding this comment.
I'm not sure I follow how that would work. Also generally, it is tricky because ingest_blocks() will get called again for any missing blocks.
What about observing the chain_head_number from the ChainHeadUpdateListener?
fordN
force-pushed
the
ford/ingestor-and-query-metrics
branch
from
801f0b6
to
0a08711
Compare
Jannis
requested changes
Dec 13, 2019
fordN
force-pushed
the
ford/ingestor-and-query-metrics
branch
from
512085d
to
7ee9d96
Compare
Jannis
approved these changes
Dec 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates two new metrics structs for instrumenting the Block Ingestor and the GraphQL server.
BlockIngestorMetricswith a gauge vec to track the number of blocks being synced from Ethereum, labeled by networks name.GraphQLServiceMetricswhich includes a histogram vec for tracking query execution time of successful queries, labeled by subgraph deployment id.