chain head listener: Reduce locking #2763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoyvens
force-pushed
the
leo/optimize-chain-head-listener-lock
branch
3 times, most recently
from
484ed12
to
e9ed1d7
Compare
leoyvens
force-pushed
the
leo/optimize-chain-head-listener-lock
branch
from
e9ed1d7
to
392d167
Compare
lutter
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In hosted a subgraph was observed to hang in
new_block_stream, which could mean hanging inChainHeadListener::subscribe, so this lock might be involved. This switches the Mutex to an RwLock which will only see write locks when the networks are first inserted, so it practically removes contention. This should at least reduce the impact of a task hanging while holding the lock. The implementation is basically what it was before #2366, but being mindful of race conditions.