Handle Ethereum Firehose decoding issues without crashing #3483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, graph-node would crash completely whenever it would encounter a Firehose block that didn't meet the expectations. In the specific example where we ran into this, there were invalid Firehose blocks delivered to graph-node with `null` addresses that were expected to be non-null. This change makes it so that decoding errors are handled more gracefully: they simply make the subgraph in question enter a retry loop that recovers as soon as the Firehose issue is fixed. We could also fail the subgraph but that's less robust. Fixes #3460.
Before, we'd only back off when failing to establish connections.
leoyvens
approved these changes
Apr 21, 2022
Co-authored-by: Leonardo Yvens <leoyvens@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3460 by using
TryFromwhen decoding Ethereum Firehose blocks and then handling the error by retrying the same block over and over again (with exponential back-off). Before, graph-node would crash completely.