Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store: Be considerate of replicas when copying #3966

Merged
merged 1 commit into from
Sep 21, 2022
Merged

store: Be considerate of replicas when copying #3966

merged 1 commit into from
Sep 21, 2022

Conversation

lutter
Copy link
Collaborator

@lutter lutter commented Sep 20, 2022

Copying of subgraphs can create a lot of data to be replicated, which can make replicas fall hopelessly behind. With this change, the copy code checks whether there are replicas that are too far behind and backs off of copying for a bit to give them a chance to catch up.

store/postgres/src/copy.rs Show resolved Hide resolved
store/postgres/src/copy.rs Show resolved Hide resolved
Copy link
Member

@neysofu neysofu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

store/postgres/src/copy.rs Show resolved Hide resolved
store/postgres/src/copy.rs Show resolved Hide resolved
Copying of subgraphs can create a lot of data to be replicated, which can
make replicas fall hopelessly behind. With this change, the copy code
checks whether there are replicas that are too far behind and backs off of
copying for a bit to give them a chance to catch up.
@lutter lutter merged commit d1004e6 into master Sep 21, 2022
@lutter lutter deleted the lutter/lag branch September 21, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants