Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graphman command for clearing the call cache for a given chain #4066

Merged
merged 14 commits into from
Oct 31, 2022
Merged

graphman command for clearing the call cache for a given chain #4066

merged 14 commits into from
Oct 31, 2022

Conversation

poonai
Copy link
Contributor

@poonai poonai commented Oct 17, 2022

close #3727

@poonai poonai marked this pull request as ready for review October 18, 2022 10:41
@leoyvens leoyvens requested a review from tilacog October 18, 2022 14:51
@tilacog tilacog self-assigned this Oct 18, 2022
tilacog
tilacog suggested changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@tilacog tilacog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this!
I appreciate that you've also written the docs for the new command. That was very thoughtful.

docs/graphman.md Outdated
@@ -6,6 +6,7 @@
- [Unused Record](#unused-record)
- [Unused Remove](#unused-remove)
- [Drop](#drop)
- [Chain Call Cache](#call-cache)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should point to the final remove subcommand,like this:

Suggested change
- [Chain Call Cache](#call-cache)
- [Chain Call Cache Remove](#call-cache-remove)

docs/graphman.md Outdated Show resolved Hide resolved
docs/graphman.md Outdated Show resolved Hide resolved
docs/graphman.md Outdated Show resolved Hide resolved
docs/graphman.md Outdated Show resolved Hide resolved
docs/graphman.md Outdated Show resolved Hide resolved
store/postgres/src/chain_store.rs Outdated Show resolved Hide resolved
store/postgres/src/chain_store.rs Outdated Show resolved Hide resolved
store/postgres/src/chain_store.rs Outdated Show resolved Hide resolved
store/postgres/src/chain_store.rs Outdated Show resolved Hide resolved
@poonai
wip
23cc4ce 
Signed-off-by: poonai <rbalajis25@gmail.com>
@poonai
wip
21c68b5 
Signed-off-by: poonai <rbalajis25@gmail.com>
@poonai
hook clear cache in chain command
fa2a0bd
@poonai
cargo fmt
4bcbff4
@poonai
add clap attribute
191cefb 
Signed-off-by: poonai <rbalajis25@gmail.com>
@poonai
update comment
3066925 
Signed-off-by: poonai <rbalajis25@gmail.com>
@poonai
add docs
9dad773 
Signed-off-by: poonai <rbalajis25@gmail.com>
@poonai
fix comments
292313f 
Signed-off-by: poonai <rbalajis25@gmail.com>
@poonai
resolve comments
748feab 
Signed-off-by: poonai <rbalajis25@gmail.com>
@poonai
cargo fmt added
f92744f 
Signed-off-by: poonai <rbalajis25@gmail.com>
@poonai poonai requested a review from tilacog October 23, 2022 12:07
@poonai
update description
cb97ad9 
Signed-off-by: poonai <rbalajis25@gmail.com>
tilacog
tilacog reviewed Oct 24, 2022
View reviewed changes
docs/graphman.md Outdated Show resolved Hide resolved
tilacog
tilacog reviewed Oct 24, 2022
View reviewed changes
docs/graphman.md Outdated Show resolved Hide resolved
@tilacog tilacog self-requested a review October 24, 2022 15:00
tilacog
tilacog reviewed Oct 24, 2022
View reviewed changes
docs/graphman.md Outdated Show resolved Hide resolved
tilacog
tilacog reviewed Oct 24, 2022
View reviewed changes
docs/graphman.md Outdated Show resolved Hide resolved
tilacog
tilacog suggested changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@tilacog tilacog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!
I've left some suggestions, most of which can be applied directly.

@poonai
resolve comments
0c7d98e 
Signed-off-by: poonai <rbalajis25@gmail.com>
@poonai
update option
d865eff 
Signed-off-by: poonai <rbalajis25@gmail.com>
@poonai
format docs
bdc8737 
Signed-off-by: poonai <rbalajis25@gmail.com>
@poonai poonai requested a review from tilacog October 25, 2022 12:01
tilacog
tilacog approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@tilacog tilacog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this!
I'll run it locally just to try it out before merging.

@tilacog tilacog merged commit ee76a63 into graphprotocol:master Oct 31, 2022
@neysofu neysofu mentioned this pull request Nov 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tilacog tilacog tilacog approved these changes

Assignees

@tilacog tilacog

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New graphman command for clearing the call cache for a given chain
2 participants
@poonai @tilacog