firehose connection loadbalance #4083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mangas
force-pushed
the
3879-firehose-conn-lb
branch
from
1710c0a
to
cce4da9
Compare
mangas
force-pushed
the
3879-firehose-conn-lb
branch
from
cce4da9
to
fef1e62
Compare
leoyvens
requested changes
Oct 20, 2022
docker/docker-compose.yml
Outdated
| volumes: | ||
| - ./data/postgres:/var/lib/postgresql/data | ||
| # volumes: | ||
| # - ./data/postgres:/var/lib/postgresql/data |
There was a problem hiding this comment.
Why this change to docker-compose?
graph/src/firehose/endpoints.rs
Outdated
| @@ -75,8 +73,7 @@ impl FirehoseEndpoint { | |||
| // Timeout on each request, so the timeout to estabilish each 'Blocks' stream. | |||
| .timeout(Duration::from_secs(120)); | |||
|
|
|||
| // Load balancing on a same endpoint is useful because it creates a connection pool. | |||
| let channel = Channel::balance_list(iter::repeat(endpoint).take(conn_pool_size as usize)); | |||
| let channel = Channel::balance_list(vec![endpoint].into_iter()); | |||
There was a problem hiding this comment.
We can make this let channel = endpoint.connect_lazy(); as it used to be.
graph/src/firehose/endpoints.rs
Outdated
| @@ -267,10 +264,12 @@ impl FirehoseEndpoints { | |||
| self.0.len() | |||
| } | |||
|
|
|||
| // selects the FirehoseEndpoint with the lest amount of references, which will help with spliting | |||
There was a problem hiding this comment.
Suggested change
| // selects the FirehoseEndpoint with the lest amount of references, which will help with spliting | |
| // selects the FirehoseEndpoint with the least amount of references, which will help with splitting |
graph/src/firehose/endpoints.rs
Outdated
| self.0.iter().choose(&mut rng) | ||
| self.0 | ||
| .iter() | ||
| .min_by(|x, y| Arc::strong_count(x).cmp(&Arc::strong_count(y))) |
graph/src/firehose/endpoints.rs
Outdated
| @@ -267,10 +264,12 @@ impl FirehoseEndpoints { | |||
| self.0.len() | |||
| } | |||
|
|
|||
| // selects the FirehoseEndpoint with the lest amount of references, which will help with spliting | |||
| // the load naively across the entire list. | |||
| pub fn random(&self) -> Option<&Arc<FirehoseEndpoint>> { | |||
There was a problem hiding this comment.
One aspect that concerns me is a silent hang if we ever hit the 100 stream limit per connection limit. Perhaps a simple way to make the error explicit would be to add a
const SUBGRAPHS_PER_CONN: usize = 100;
And return an error if the ref count reaches this number. Or even better auto-scale based on this.
There was a problem hiding this comment.
will address this on a separate PR as this could benefit from some metrics in order to detect a stall
mangas
force-pushed
the
3879-firehose-conn-lb
branch
from
fef1e62
to
b45207f
Compare
leoyvens
approved these changes
Oct 21, 2022
| .min_by_key(|x| Arc::strong_count(x)) | ||
| .ok_or(anyhow!("no available firehose endpoints"))?; | ||
| if Arc::strong_count(endpoint) > SUBGRAPHS_PER_CONN { | ||
| return Err(anyhow!("all connections saturated with {} connections, increase the firehose conn_pool_size", SUBGRAPHS_PER_CONN)); |
There was a problem hiding this comment.
Nice work with the actionable error message!
|
Oh and lets bump the default to 20. |
leoyvens
approved these changes
Oct 21, 2022
mangas
force-pushed
the
3879-firehose-conn-lb
branch
from
37ce27d
to
03c2911
Compare
mangas
force-pushed
the
3879-firehose-conn-lb
branch
from
abb00a5
to
dc91e76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3879