Fix limit handling on rpc configuration #4353
Conversation
mangas
commented
Feb 9, 2023
•
mangas
commented
- Set 0 for Disabled
- Omitted hosts can are disabled if list of rules is not empty
- Empty rules = Unlimited
- Limit != 0 does exactly what you'd think it does
mangas
force-pushed
the
filipe/fix-rpc-limit
branch
4 times, most recently
from
426c183
to
d5813c8
Compare
| Limit(usize), | ||
| NoTraffic, | ||
| Unlimited, | ||
| } |
There was a problem hiding this comment.
Do we really need this enum? I don't really think it buys us much above using a plain usize (where Disabled -> 0 and Unlimited -> usize::MAX)
There was a problem hiding this comment.
It's mostly to improve readability since otherwise we'd need to set a value for 0 and some for "not set" in order to differentiate so there would be a few places with Option where we were not sure of the meaning. Also Unlimited will also get transformed in the different adapters, eg firehose uses 100 max so it gets set to the adapter-specific "maximum"
There was a problem hiding this comment.
LGTM.
The file docs/config.md also needs an update: the sentence
Any node whose name does not match one of these patterns will use mainnet-0 and mainnet-1 for an unlimited number of subgraphs.
needs to be changed to say that nodes whose names do not match will not use that provider
| None => self.cheapest_with(capabilities.unwrap_or(&NodeCapabilities { | ||
| // call_only_adapter can fail if we're out of capcity or,this is fine since | ||
| // we would want to fallback onto a full adapter | ||
| // so we will ignore this error and return whatever comes out of `cheapest_with` |
There was a problem hiding this comment.
I don't fully understand this comment, especially the 'or, this is fine' throws me off
There was a problem hiding this comment.
I initially had something else there :P I will fix this, good catch :)
mangas
force-pushed
the
filipe/fix-rpc-limit
branch
from
b93d196
to
abdc840
Compare
- Set 0 for unlimited - Unset hosts can make no calls - Limit != 0 does exactly what you'd think it does
mangas
force-pushed
the
filipe/fix-rpc-limit
branch
from
abdc840
to
cfcb5fc
Compare
