all: Make graphman chain call-cache remove safer
#4397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The command defaulted to the dangerous operation of clearing the entire cache. Now, the entire cache can only be cleared by passing the annoyingly named `--remove-entire-cache`. In a similar vein, it used to be ok to omit --from or --to which would default to the first or last block. They now need to both be specified to make the user be clearer about how much of the call cache they are going to remove.
lutter
force-pushed
the
lutter/remove-call-cache
branch
from
c4456c4
to
4fb2cc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command defaulted to the dangerous operation of clearing the entire cache. Now, the entire cache can only be cleared by passing the annoyingly named
--remove-entire-cache.In a similar vein, it used to be ok to omit --from or --to which would default to the first or last block. They now need to both be specified to make the user be clearer about how much of the call cache they are going to remove.