Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chain,node: Add support to skip setting gas field for certain chains #4609

Merged
merged 3 commits into from
May 11, 2023

Conversation

incrypto32
Copy link
Contributor

Solves #4608

Copy link
Collaborator

@leoyvens leoyvens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I just have some minor comments.

chain/ethereum/src/env.rs Outdated Show resolved Hide resolved
chain/ethereum/src/env.rs Outdated Show resolved Hide resolved
chain/ethereum/src/ethereum_adapter.rs Outdated Show resolved Hide resolved
chain/ethereum/src/runtime/runtime_adapter.rs Outdated Show resolved Hide resolved
@incrypto32 incrypto32 force-pushed the incrypto32/skip-eth-call-gas-conditionally branch from 53b61d6 to 7f44ab7 Compare May 10, 2023 17:14
@incrypto32 incrypto32 requested a review from leoyvens May 10, 2023 17:16
@leoyvens leoyvens marked this pull request as ready for review May 11, 2023 09:55
@incrypto32 incrypto32 merged commit 2ebec0a into master May 11, 2023
6 checks passed
@incrypto32 incrypto32 self-assigned this Jul 20, 2023
@incrypto32 incrypto32 deleted the incrypto32/skip-eth-call-gas-conditionally branch March 12, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants