Handle conn pool initialization gracefully #4778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mangas
commented
Jul 24, 2023
mangas
commented
- Duplicated labels no longer allowed on config
- Endpoints get tested/connected to per provider label instead of per endpoint
mangas
force-pushed
the
filipe/conn-pool-graceful-init
branch
from
1aef145
to
9757b0a
Compare
neysofu
approved these changes
Jul 24, 2023
- Duplicated labels no longer allowed on config - Endpoints get tested/connected to per provider label instead of per endpoint
mangas
force-pushed
the
filipe/conn-pool-graceful-init
branch
from
9757b0a
to
7e04c65
Compare
|
So that this avoid doing N firehose endpoint check and does only one per provider is that correct? |
|
If it's true, I think we can safely close #4323, we should still probably change the default |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.