Add subgraph paused status to index node API #4779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mangas
reviewed
Aug 7, 2023
| status | ||
| .paused | ||
| .map(|b| b.to_string()) | ||
| .unwrap_or("---".to_string()), |
There was a problem hiding this comment.
This is for a new row in the graphman info command, it will just print out a table and this line just adds a new line with the paused status of that subgraph
There was a problem hiding this comment.
I still dont understand why --- rather than defaulting to a sensible value like "false"?
There was a problem hiding this comment.
I'm approving to unblock but I'd rather change this, however I'll leave that decision to you
There was a problem hiding this comment.
Its a placeholder for None the value is a Option<bool>
mangas
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4667