Retry block_pointer_from_number on deploy #4812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mangas
force-pushed
the
filipe/retry-block-number-on-deployment
branch
from
1742b25
to
e32f7fc
Compare
neysofu
reviewed
Aug 21, 2023
core/src/subgraph/registrar.rs
Outdated
Comment on lines
539
to
555
| fn retry_strategy(limit_opt: Option<usize>) -> Box<dyn Iterator<Item = Duration> + Send> { | ||
| // Exponential backoff, but with a maximum | ||
| let max_delay_ms = 30_000; | ||
| let backoff = ExponentialBackoff::from_millis(2) | ||
| .max_delay(Duration::from_millis(max_delay_ms)) | ||
| .map(jitter); | ||
|
|
||
| // Apply limit (maximum retry count) | ||
| match limit_opt { | ||
| Some(limit) => { | ||
| // Items are delays *between* attempts, | ||
| // so subtract 1 from limit. | ||
| Box::new(backoff.take(limit - 1)) | ||
| } | ||
| None => Box::new(backoff), | ||
| } | ||
| } |
There was a problem hiding this comment.
This looks identical to graph::util::futures::retry_strategy, correct? If so, we can make that public and reuse it here, and also avoid pub use tokio_retry.
Add retry to avoid a single failure while making the call prevent the subsgraph from being deployed Add warning for failed attempts
mangas
force-pushed
the
filipe/retry-block-number-on-deployment
branch
from
e32f7fc
to
dfb4dd0
Compare
neysofu
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add retry to avoid a single failure while making the call prevent the subsgraph from being deployed Add warning for failed attempts
Closes #4724