Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow creating partial indexes with graphman #4830

Merged
merged 3 commits into from
Sep 13, 2023
Merged

Allow creating partial indexes with graphman #4830

merged 3 commits into from
Sep 13, 2023

Conversation

incrypto32
Copy link
Contributor

@incrypto32 incrypto32 commented Aug 28, 2023 •
edited

lutter
lutter reviewed Aug 28, 2023
View reviewed changes
Copy link
Collaborator

@lutter lutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good so far!

store/postgres/src/deployment_store.rs Outdated Show resolved Hide resolved
store/postgres/src/deployment_store.rs Show resolved Hide resolved
store/postgres/src/deployment_store.rs
})
.collect::<Vec<String>>()
.join(",")
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@incrypto32 incrypto32 merged commit 2a336df into master Sep 13, 2023
6 checks passed
@incrypto32 incrypto32 deleted the incrypto32/index-for-prefixed-fields branch September 13, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lutter lutter lutter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] graphman index create does not respect prefixed fields [Feature] Create partial indexes
2 participants
@incrypto32 @lutter