Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add substreams block ingestor #4839

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Add substreams block ingestor #4839

merged 2 commits into from
Sep 11, 2023

Conversation

mangas
Copy link
Contributor

@mangas mangas commented Aug 29, 2023

  • Substreams ingestor not currently allowed for supported chains
  • Chains using substreams protocol can only have substreams endpoints
  • Add substream-head-tracker to the project
  • Embed substreams-head-tracker in substreams block ingestor

- Substreams ingestor not currently allowed for supported chains
- Chains using substreams protocol can only have substreams endpoints
- Add substream-head-tracker to the project
- Embed substreams-head-tracker in substreams block ingestor
@mangas mangas marked this pull request as ready for review August 29, 2023 14:52
@@ -0,0 +1,4 @@
[toolchain]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would we have a way to use the top-level one directly. Only thing I'm wondering is the wasm32-unknown-unknown target.

@fordN fordN requested a review from neysofu September 5, 2023 15:54
Copy link
Member

@neysofu neysofu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I have the necessary context to thoroughly review this, so it's great to have other eyes on this. This is pretty in line with what I would expect though, LGTM.

node/src/config.rs Show resolved Hide resolved
@mangas mangas merged commit e5261f8 into master Sep 11, 2023
6 checks passed
@mangas mangas deleted the substreams-block-ingestor branch September 11, 2023 12:50
latest_cursor = self.process_blocks(latest_cursor, stream).await;

// If we reach this point, we must wait a bit before retrying
backoff.sleep_async().await;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like backoff is never reset, which is not ideal. Maybe should reset if cursor changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants