Refactor index creation and fix unncessary prefix #4995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
incrypto32
force-pushed
the
krishna/graphman-index-prefix-fix
branch
3 times, most recently
from
4d74385
to
8665a27
Compare
incrypto32
force-pushed
the
krishna/graphman-index-prefix-fix
branch
from
8665a27
to
59f2f19
Compare
lutter
approved these changes
Nov 27, 2023
| pub fn calculate_index_method_and_expression( | ||
| immutable: bool, | ||
| column: &Column, | ||
| ) -> (String, String) { |
There was a problem hiding this comment.
There's an enum for index methods here - it would be better to use that. I wonder if that should return the whole CreateIndex from that file instead of the second string, but that might become a bit too unwieldy. Maybe some or all of this logic should go into a new constructor for CreateIndex
There was a problem hiding this comment.
Actually, I think what I said above would be good for another refactor, but what you have here is ok for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4982