Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more controls on historyBlocks in manifest #5117

Merged
merged 9 commits into from
Jan 16, 2024

Conversation

incrypto32
Copy link
Contributor

No description provided.

graph/src/env/mod.rs Outdated Show resolved Hide resolved
graph/src/data/subgraph/mod.rs Outdated Show resolved Hide resolved
graph/src/env/mod.rs Outdated Show resolved Hide resolved
@leoyvens
Copy link
Collaborator

@incrypto32 looking good, one last thing, can we change the grapman prune default history blocks to also be 2 * reorg_threshold? For consistency across ways of pruning.

@leoyvens
Copy link
Collaborator

leoyvens commented Jan 11, 2024

Chatting to @Data-Nexus, we don't want the syntax to spook subgraph devs if they understand 'historical' as meaning entities that are just old, and that we'd delete their entities just because they are old. An alternative syntax could be:

indexerHints:
  prune: [auto|never|<number>]

This way the default

indexerHints:
  prune: auto

Looks as friendly and reassuring as a piece of YAML can.

@schmidsi
Copy link
Member

I agree that "prune" is probably the better word. See: https://dictionary.cambridge.org/us/dictionary/english/prune.

to reduce something by removing things that are not necessary

node/src/bin/manager.rs Show resolved Hide resolved
@incrypto32 incrypto32 merged commit 6fe6676 into master Jan 16, 2024
7 checks passed
@incrypto32 incrypto32 deleted the krishna/history-blocks-fix branch January 16, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants