improve error log #5217
Merged
improve error log #5217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mangas
commented
Feb 19, 2024
| @@ -308,7 +308,7 @@ async fn process_substreams_response<C: Blockchain, F: BlockStreamMapper<C>>( | |||
| match mapper | |||
| .to_block_stream_event(logger, response.message, log_data) | |||
| .await | |||
| .context("Mapping message to BlockStreamEvent failed")? | |||
| .map_err(BlockStreamError::from)? | |||
There was a problem hiding this comment.
Context was turning this error into a anyhow Error which was in turn then not showing the full details of the underlying error
mangas
force-pushed
the
improve-err-log
branch
2 times, most recently
from
055bfe3
to
614892d
Compare
mangas
force-pushed
the
improve-err-log
branch
from
614892d
to
45ccc8b
Compare
lutter
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve substreams block stream error reporting.