Make batching conditional on caught-up status #5252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This takes a different approach to PR #5198. Importantly, it will properly disable batching if the subgraph is caught up with the chain, regardless of the 'synced' flag status. It separates the related concepts of synced and caught-up, and moves handling that into transact_block_operations`.
lutter
approved these changes
Feb 28, 2024
lutter
reviewed
Feb 28, 2024
| @@ -338,16 +338,15 @@ pub trait WritableStore: ReadStore + DeploymentCursorTracker { | |||
| deterministic_errors: Vec<SubgraphError>, | |||
| offchain_to_remove: Vec<StoredDynamicDataSource>, | |||
| is_non_fatal_errors_active: bool, | |||
| is_caught_up_with_chain_head: bool, | |||
There was a problem hiding this comment.
Maybe worth commenting what behavior this triggers
|
So that we don't flip-flop batching too often, and so that we don't have to think too hard about off-by-one situations and small latency lags affecting this, the subgraph is now considered synced if it's 10 blocks behind chain head, rather than just 1 block. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes a different approach to PR #5198. Importantly, it will properly disable batching if the subgraph is caught up with the chain, regardless of the 'synced' flag status, fixing a regression.
It separates the related concepts of synced and caught-up, and moves handling that into transact_block_operations`. This nicely allows us to resume batching once caught up.
Resolves #5251.