Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derived Loader Fixes #1340

Merged
merged 11 commits into from May 30, 2023
Merged

Derived Loader Fixes #1340

merged 11 commits into from May 30, 2023

Conversation

incrypto32
Copy link
Contributor

This PR completes #1190

  • Fixes some issues with Immutable JS while rebasing
  • Fixes wrong type names being generated for derived loaders

@changeset-bot
Copy link

changeset-bot bot commented May 4, 2023

🦋 Changeset detected

Latest commit: 8b6534a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@graphprotocol/graph-ts Minor
@graphprotocol/graph-cli Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphprotocol/graph-cli 0.49.0-alpha-20230530202807-8b6534a npm ↗︎ unpkg ↗︎
@graphprotocol/graph-ts 0.30.0-alpha-20230530202807-8b6534a npm ↗︎ unpkg ↗︎

@incrypto32 incrypto32 requested a review from saihaj May 4, 2023 17:27
@incrypto32 incrypto32 changed the title Dervied Loader Fixes Derived Loader Fixes May 4, 2023
@incrypto32 incrypto32 force-pushed the incrypto32/derived-loader-fixes branch from d3fbf0b to 987eca2 Compare May 5, 2023 10:33
@@ -26,6 +26,7 @@ export declare namespace store {
/** If the entity was not created in the block, this function will return null. */
// Matches the host function https://github.com/graphprotocol/graph-node/blob/9f4a1821146b18f6f49165305e9a8c0795120fad/runtime/wasm/src/module/mod.rs#L1091-L1099
function get_in_block(entity: string, id: string): Entity | null;
function loadRelated(entity: string, id: string, field: string): Array<Entity>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a changeset for explaining the upgrade to graph-ts

Copy link
Member

@saihaj saihaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great in terms of feature. Few nits on code which we should fix and then good to merge

packages/cli/src/codegen/schema.ts Outdated Show resolved Hide resolved
packages/cli/src/codegen/schema.ts Outdated Show resolved Hide resolved
packages/cli/src/type-generator.ts Show resolved Hide resolved
@azf20 azf20 mentioned this pull request May 5, 2023
@incrypto32 incrypto32 force-pushed the incrypto32/derived-loader-fixes branch from bf9efcf to c3a15e4 Compare May 30, 2023 18:40
@incrypto32 incrypto32 requested a review from saihaj May 30, 2023 18:42
@saihaj saihaj enabled auto-merge (squash) May 30, 2023 20:31
@saihaj saihaj merged commit 2375877 into main May 30, 2023
8 checks passed
@saihaj saihaj deleted the incrypto32/derived-loader-fixes branch May 30, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants