Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nested array from tuple and schema generation #1433

Merged
merged 4 commits into from Sep 1, 2023

Conversation

saihaj
Copy link
Member

@saihaj saihaj commented Aug 31, 2023

Adds bunch of debug logs that in future should make debugging generation issues easier.

  1. Main thing is that today any nested arrays were unable to be processed. With this PR we can validate any nested array in GraphQL Schema.
  2. We generate types from tuple and we want all those generated arrays to be Non-Nullable to avoid any user confusion

closes #1399

@changeset-bot
Copy link

changeset-bot bot commented Aug 31, 2023

🦋 Changeset detected

Latest commit: 3d319d2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphprotocol/graph-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@saihaj saihaj changed the title fix: nester array from tuple and schema generation fix: nested array from tuple and schema generation Aug 31, 2023
@github-actions
Copy link
Contributor

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphprotocol/graph-cli 0.56.1-alpha-20230831035057-3d319d2 npm ↗︎ unpkg ↗︎

@saihaj saihaj merged commit 4492e4f into main Sep 1, 2023
10 checks passed
@saihaj saihaj deleted the saihaj/multiple-array branch September 1, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subgraph.yaml: Cannot read properties of undefined (reading 'value')
1 participant