fix: remove validate studio network checks #1521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
9c86c12
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5f382ab4.graph-tooling.pages.dev |
| Branch Preview URL: | https://saihaj-i1509.graph-tooling.pages.dev |
🦋 Changeset detectedLatest commit: 9c86c12 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
azf20
requested changes
Nov 24, 2023
| @@ -245,8 +244,6 @@ export default class InitCommand extends Command { | |||
| subgraphName, | |||
| contractName, | |||
| node, | |||
| studio, | |||
There was a problem hiding this comment.
Is this already removing some arguments from init?
There was a problem hiding this comment.
no we are not removing any args. This is simply removing the validation check since we only do that check during init fro studio. Should not change any args.
azf20
approved these changes
Nov 24, 2023
dotansimha
approved these changes
Nov 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Studio will take care of this and we don't need to maintain a list for supported networks.
closes #1509