De-duplicate event names and contract function names #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
@leodasvacas Yes, |
|
Could even do |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix in this PR is sufficient to fix the name duplication issues for event classes and contract methods observed in the decentraland subgraph, by using a numbering scheme for events and methods with the same name.
To fully address #168 there is still the issue of having
event SetPermissionandevent SetPermissionParams, which is a total edge case. There I'm reluctant of going for a numbering scheme, which I think would over complicate the situation. Since...Paramstypes are not usually imported into mappings, it would be mostly backwards compatible to rename them. So can I fix this by just changing the suffix to...EventParams?