Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor rav requester #112

Merged
merged 4 commits into from Jan 23, 2024
Merged

Refactor rav requester #112

merged 4 commits into from Jan 23, 2024

Conversation

aasseman
Copy link
Collaborator

It's smaller than it looks, most of the diff is about splitting rav_quester_try() into multiple functions to help with readability.

@aasseman
refactor(tap-agent): simplify rav_requester task
f265d36 
Signed-off-by: Alexis Asseman <alexis@semiotic.ai>
@aasseman
refactor(tap-agent): split rav_requester_try
161dced 
Signed-off-by: Alexis Asseman <alexis@semiotic.ai>
@aasseman aasseman added size:small Small p2 Medium priority type:refactor Changes not visible to users labels Jan 18, 2024
@aasseman aasseman self-assigned this Jan 18, 2024
@aasseman
fix: update sqlx metadata
8787492 
Signed-off-by: Alexis Asseman <alexis@semiotic.ai>
@aasseman
test: more robust wait in sender_allocation_relationship
fff183d 
Signed-off-by: Alexis Asseman <alexis@semiotic.ai>
@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 7577617496

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 62.394%
Totals Coverage Status
Change from base Build 7549373716: 0.02%
Covered Lines: 2361
Relevant Lines: 3784
💛 - Coveralls

gusinacio
gusinacio approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that the rav_requester_task is now a long-running task and it's not being spawned on-demand.

LGTM

@aasseman aasseman merged commit 6a0eed3 into main Jan 23, 2024
8 checks passed
@aasseman aasseman deleted the aasseman/refactor-rav-requester branch January 23, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gusinacio gusinacio gusinacio approved these changes

Assignees

@aasseman aasseman

Labels
p2 Medium priority size:small Small type:refactor Changes not visible to users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aasseman @gusinacio