Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): subgraph monitor query #114

Merged
merged 1 commit into from Feb 1, 2024

Conversation

aasseman
Copy link
Collaborator

@aasseman aasseman commented Feb 1, 2024

The subgraph client monitor was sending malformed queries to graph-node.

subgraph monitor logs:

WARN indexer_common::subgraph_client::monitor: Error querying deployment status for `QmP9foCa7YRvQJCtrdPV1zu1yVovwagEpcDSarvmQKS642`: Failed to query status of deployment `QmP9foCa7YRvQJCtrdPV1zu1yVovwagEpcDSarvmQKS642`: Error deserializing GraphQL response body: expected value at line 1 column 1

Graph-node logs:

ERRO IndexNodeService call failed: GraphQL server error (query error): query parse error: Parse error at 1:2\nUnexpected `"query"[StringValue]`\nExpected `Name`\n, component: IndexNodeServer

Changing the query body to use indexer_common::subgraph_client::client:Query fixes the problem.

I also fixed a small inconsequential typo: graph-node's status GQL API actually expects the deployment IDs to be of type String, and not ID, according to the introspected schema.

Tested against the local-network.

Signed-off-by: Alexis Asseman <alexis@semiotic.ai>
@aasseman aasseman added size:small Small p1 High priority type:bug Something isn't working labels Feb 1, 2024
@aasseman aasseman requested a review from Jannis February 1, 2024 02:23
@aasseman aasseman self-assigned this Feb 1, 2024
Copy link
Contributor

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

github-actions bot commented Feb 1, 2024

Pull Request Test Coverage Report for Build 7735357667

  • 0 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 63.265%

Totals Coverage Status
Change from base Build 7632720048: -0.03%
Covered Lines: 2461
Relevant Lines: 3890

💛 - Coveralls

@aasseman aasseman merged commit b55af5d into main Feb 1, 2024
8 checks passed
@aasseman aasseman deleted the aasseman/fix_common_subgraph_monitor branch February 1, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1 High priority size:small Small type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants