Remove indexer management GraphQL API #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jannis
force-pushed
the
jannis/remove-management-graphql-api
branch
from
09eef22
to
858e59f
Compare
Jannis
changed the title
aasseman
added
size:small
This API is not supposed to be exposed by the indexer service. It is something that only indexer agent runs to give indexer CLI and other tools the ability to configure the indexer agent behavior.
Among other things, this makes Emacs happy.
Jannis
force-pushed
the
jannis/remove-management-graphql-api
branch
from
858e59f
to
ca15834
Compare
Jannis
commented
Sep 18, 2023
service/src/server/mod.rs
Outdated
| @@ -92,12 +88,6 @@ pub async fn create_server( | |||
| get(routes::deployment::deployment_health | |||
| .layer(AddExtensionLayer::new(slow_ratelimiter()))), | |||
| ) | |||
| .route( | |||
There was a problem hiding this comment.
Oops, good catch, I went too far here. 🤦🏻
I'll put the cost model resolver(s) back.
Jannis
force-pushed
the
jannis/remove-management-graphql-api
branch
from
8b704db
to
01dc018
Compare
Jannis
force-pushed
the
jannis/remove-management-graphql-api
branch
from
01dc018
to
db65564
Compare
hopeyen
reviewed
Sep 18, 2023
| let pool = &ctx.data_unchecked::<ServerOptions>().indexer_management_db; | ||
| indexer_management::cost_model(pool, &deployment).await | ||
| } | ||
| } | ||
|
|
||
| pub(crate) async fn graphql_handler( |
There was a problem hiding this comment.
In the spirit of remove indexer management graphQL API, perhaps we remove graphql_handler and use a different handler for the cost requests?
There was a problem hiding this comment.
This is the public cost model API that indexer-service exposes as well — and that is a GraphQL API. So this is correct.
hopeyen
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This API is not supposed to be exposed by the indexer service. It is something that only indexer agent runs to give indexer CLI and other tools the ability to configure the indexer agent behavior.