Shorten failure reason stored #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hopeyen
force-pushed
the
hope/failure-reason
branch
3 times, most recently
from
f46fb69
to
5439ed1
Compare
hopeyen
force-pushed
the
hope/failure-reason
branch
from
5439ed1
to
894521a
Compare
hopeyen
changed the title
fordN
reviewed
Aug 16, 2022
hopeyen
force-pushed
the
hope/failure-reason
branch
from
894521a
to
b5856dd
Compare
hopeyen
force-pushed
the
hope/failure-reason
branch
from
b5856dd
to
6f19750
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #444
Currently the failure reason column gets populated by the error log message if a transaction fails. These log messages were designed to be logged to stdout not to be stored in a DB column. Occasionally the messages seem to hit the limit
SequelizeDatabaseError: value too long for type character varying(1000).We update the failure reasons to be shorter strings. For the actions that failed due to an existing
IndexerError, we simply store the error code asIE0XXso people can look up the reasons and solutions if provided. We also added more variations of IndexerError to cover the failure cases here with the action manager.