Indexer-common: Fix automatic rule creation upon confirmed action execution #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hopeyen
approved these changes
Aug 29, 2022
- Use correct allocationAmount Bignumber formatting when auto creating rules - Always upsert an offchain rule when confirming unallocate actions - Move some indexing-rule utils to indexer-common - Add test for inserting and fetching rule helper functions - Improve failed confirmTransactions error message
fordN
force-pushed
the
ford/fix-auto-rule-creation-allocation-amount
branch
from
8811b98
to
587bb64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR primarily contains a few important fixes to the auto rule creation that is done after a manual action is executed.
Fixes included:
offchainrule after anunallocateaction to ensure the agent doesn't recreate the allocation.Small improvements made while updating: