indexer-common: Fix bug in isDeploymentWorthAllocatingTowards() #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The bug affected indexing-rules using `minSignal` thresholds without a
'maxSignal' threshold set
- Also made some minor updates to:
- update error reference page url: use `main` branch
- use consistent subgraph naming convention:
`indexer-agent/${networkSubgraphDeployment.ipfsHash.slice(-10)}`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug affected indexing-rules using
minSignalthresholds without a 'maxSignal' threshold set. In this scenario the indexer-agent would find all rules above theminSignalthreshold not worthy of allocating to because they didn't also have amaxSignalthreshold set. This check has now been fixed to only use themaxSignalthreshold if one is set.I also took the opportunity to make some minor updates to:
mainbranchindexer-agent/${networkSubgraphDeployment.ipfsHash.slice(-10)}.