Indexer-agent: remove fallback to hardcode default file #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, I like the goal of this PR, but the code changes should be much simpler. Looking at the code changes though it seems there is other work mixed in with it? It seems to be based off the |
hopeyen
force-pushed
the
hope/remove-default-agora-file
branch
from
046a620
to
bbcaf54
Compare
You're right! I rebased this branch to main, shouldn't depend on the other PR anymore |
hopeyen
force-pushed
the
hope/remove-default-agora-file
branch
from
bbcaf54
to
b435892
Compare
fordN
reviewed
Sep 27, 2022
hopeyen
force-pushed
the
hope/remove-default-agora-file
branch
from
b435892
to
245e4df
Compare
hopeyen
force-pushed
the
hope/remove-default-agora-file
branch
from
245e4df
to
f7df2bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
ensureGlobalCostModelandreconcileCostModelfrom indexer agent as they clutter the agent without any real changes towards the cost models.Now indexers should simply set global default cost model through indexer-CLI such as