Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call yarn clean in the release script. #648

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Conversation

tilacog
Copy link
Contributor

@tilacog tilacog commented Apr 18, 2023

No description provided.

Previously, it would delete the node_modules directory before calling
lerna, which would not exist because it just got removed.

With this change, lerna acts before being removed from the root
node_modules directory.
The clean command will also remove other directories as well.
@tilacog tilacog requested a review from fordN April 18, 2023 20:25
@tilacog tilacog self-assigned this Apr 18, 2023
Copy link
Contributor

@fordN fordN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fordN fordN added the enhancement New feature or request label Nov 27, 2023
@fordN fordN merged commit 0c995ad into main Dec 5, 2023
10 checks passed
@fordN fordN deleted the tiago/clean-before-releasing branch December 5, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🚗 Merged
Development

Successfully merging this pull request may close these issues.

None yet

2 participants